-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17897: Build and publish assisted-service-el8 image #52320
MGMT-17897: Build and publish assisted-service-el8 image #52320
Conversation
@carbonin: This pull request references MGMT-17897 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
51d101b
to
fa4dea8
Compare
@@ -167,6 +173,15 @@ tests: | |||
SOURCE_IMAGE_REF: assisted-service | |||
test: | |||
- ref: assisted-baremetal-images-publish | |||
- as: mirror-nightly-image-el8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for a build after a commit is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, missed the second job.
This image is required for assisted-service to be able to install clusters of version <4.16 in FIPS environments. Resolves https://issues.redhat.com/browse/MGMT-17897
fa4dea8
to
d5e3566
Compare
[REHEARSALNOTIFIER]
A total of 84 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, carbonin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/pj-rehearse ack |
@carbonin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@carbonin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This image is required for assisted-service to be able to install clusters of version <4.16 in FIPS environments.
Resolves https://issues.redhat.com/browse/MGMT-17897
cc @adriengentil
Leaving as WIP until openshift/assisted-service#6347 is merged (adds the Dockerfile)